EXPERIMENTAL: Update to use alpha version of mockwebserver3-junit5 #500
+38
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nit5 This is an experimental branch, not intended to commit to main since it is using an alpha version of OkHttp's MockWebServer which is using experimental APIs, subject to change. This is mainly to show how we can change when OkHttp 5.0.0 is released. It is also to ensure we keep up with changes to the alpha APIs. Details: * Change POM to use mockwebserver3-junit5 5.0.0-alpha.14 instead of mockwebserver 4.12.0 * Fix imports in RecordedRequests/Test (they're now just "import mockwebserver3.*" * Update RecordedRequestsTest to use MockWebServerExtension and inject it into the setup method. No longer need to explicitly close it, since the extension handles that. Change instantiations of MockResponse since they've changed them such that the Kotlin code uses JvmOverloads to generate a bunch of constructors for use by Java code. * Revert KiwiXmlAssertTest to use isExactlyInstanceOf instead of isInstanceOf and add a TODO whether we should actually do that or leave as isInstanceOf.
sleberknight
added
the
investigation
sleberknight
changed the title
sleberknight
changed the title
|
|
Keeping the branch (for now) but closing the PR, since it is not intended to be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an experimental branch, not intended to commit to main since it is using an alpha version of OkHttp's MockWebServer which is using experimental APIs, subject to change. This is mainly to show how we can change when OkHttp 5.0.0 is released. It is also to ensure we keep up with changes to the alpha APIs.
Details: